-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update marked to ^0.7.0 #102
Conversation
Upstream recommends third-party packages (e.g. DOMPurify, sanitize-html or insane) to sanitize html. I don't see the need of it in the context of server-side rendering, but can be considered if there are interests. |
I believe you should keep the sanitize option as it applies to the plugin option, not marked. |
I think it applies to both plugin and marked. I'll do some more testing. |
I'm still not sure what these lines do (which I restored in the last commit), hexo-renderer-marked/lib/renderer.js Lines 41 to 47 in e6752e5
I tried Above line added by @NoahDragon #34 Edit: I got it working through href = decodeURIComponent(href)
.replace(/[^\w:\/\.]/g, '')
.toLowerCase() || ''; not sure if it's what the original code intended. |
LGTM. It should trigger a minor version update when we publish a new version (due to change of behavior) |
It should be a major version due to #98. |
Agreed. I merge |
New version 2.0.0-RC1 published |
Here is my test tomap/hexo-theme-minidyne-demo#2 |
https://snyk.io/vuln/SNYK-JS-MARKED-451341
sanitize:
andtables:
options have been deprecated.tables:
is now part ofgfm:
.Changelog
Security
Breaking Changes
Fixes
Tests
Closes #101